search

TwitchLib / TwitchLib.PubSub

PubSub component of TwitchLib.
38 stars 51 forks source link

Channel Points Support #48

Closed BarRaider closed 4 years ago

BarRaider commented 4 years ago

Added support for receiving events when Channel Points are redeemed

JayJay1989 commented 4 years ago

is already in dev https://github.com/TwitchLib/TwitchLib.PubSub/pull/41

sadmoody commented 4 years ago

I stayed up until 4:30am last night putting together Channel Points support too. Was going to push it in through in a couple hours once everything was cleaned up. See my reaction - it was recorded.

https://clips.twitch.tv/ElatedPleasantCroissantPupper

Also please push #41 to master branch!

BarRaider commented 4 years ago

+1 please update the master branch, this is causing throwaway work from people who use this lib and want to contribute :-\

JayJay1989 commented 4 years ago

+1 please update the master branch, this is causing throwaway work from people who use this lib and want to contribute :-\

Indeed.

Mahsaap commented 4 years ago

sure, but keep in mind most if not all use dev for changes, Master normally doesn't update very often (or at least it should be that way). That being said it is in need to update and only Swift can do it. That I know of.

Mahsaap commented 4 years ago

Additionally when master changes it gets pushed to nuget, soooo this is why we use dev brand incase it breaks. Dev is also pushed to nuget like a nightly. given there is a change that day.

BarRaider commented 4 years ago

Totally understand and appreciate all the work..! Maybe updating the readme stating master is rarely updated (it's been 3 months) and to look at dev branch will help people who are less aware of what's the common practice on this repo...

Mahsaap commented 4 years ago

I have already added a small note to the readme in pr