search

TwitchLib / TwitchLib.PubSub

PubSub component of TwitchLib.
38 stars 52 forks source link

Update to CommunityPointsChannel and TwitchPubSub #66

Closed Omsad closed 3 years ago

Omsad commented 3 years ago

  1. Updates CommunityPointsChannel class to handle unknown message types in a graceful manner rather than throwing an exception when they won't parse as a RewardRedeemed message.

  2. Updates TwitchPubSub to: a. Handle access to the _previousRequests in a thread safe manner. b. Remove previous request from the _previousRequests when they are fulfilled. c. Implement a pong timer so that disconnections can be detected when no message is returned from a sent ping message. d. Raise a disconnect event when a reconnect message is received to allow the consuming class to know the connection will be closed and needs to be re-opened.

Omsad commented 3 years ago

I've retargeted to dev.

Syzuna commented 3 years ago

LGTM.

merging