Closed cetteup closed 2 years ago
Thanks for the big contribution! Very nice refactorings/base extractions. The structure is good! Top notch integration.
I'm committing some minor cleanups after merging the PR, which are mainly just taste preferences.
ServiceCollectionExtensions.cs
so that DI based environments could also inject the new services (and mock them in tests)GameName
class member to config base class since it's used in every configThank you! 🚀
Added support for reading name only for Battlefield 1942 and Vietnam, since these don't support clan tags/prefixes. Battlefield 2142 gets supported with name + prefix, since it is almost identical to Battlefield 2.
Changes
Let me know if there's anything about the new structure that needs to be changes (I am mostly clueless with C# after all).