search

TwitchPlaysPokemon / pokecat

4 stars 4 forks source link

Improve handling of biddable and hidden fields #10

Open ferraro1 opened 5 years ago

ferraro1 commented 5 years ago

Sets more intelligent values when these fields are left unspecified. This in turn removes superfluous "both biddable and hidden" warnings.

Felk commented 5 years ago

Does this need a reviewer?

ferraro1 commented 5 years ago

I think it's fine, but I made a PR in case someone wanted to eyeball it and comment

Felk commented 5 years ago

I left some comments, rest looks good

ferraro1 commented 5 years ago

I don't see any comments for this PR though. What's the url that shows me your comments? I'm looking at https://github.com/TwitchPlaysPokemon/pokecat/pull/10/files

Felk commented 5 years ago

just https://github.com/TwitchPlaysPokemon/pokecat/pull/10 https://imgur.com/yJoUG4j

ferraro1 commented 5 years ago

Here's what I see at that link: https://imgur.com/a/VwOSQFa Don't you need to click submit review?

Felk commented 5 years ago

oops, yea :)