search

TwitchPlaysPokemon / tpp-core

Core re-write for TwitchPlaysPokemon, WIP, contributions welcome
MIT License
30 stars 8 forks source link

Directed Inputs in Sided Mode should be deprioritized #419

Closed m4-used-rollout closed 1 month ago

m4-used-rollout commented 2 months ago

The L and R prefix for either side clashes with the L and R buttons and the L and R analog sticks on the Switch controller. The Sided Input Parser needs to prioritize valid buttons first, and only treat a leading L or R as a side prefix if it's not part of any valid button names.

m4-used-rollout commented 2 months ago

For example, "rup" is not a valid input on GameBoy, so it should parse as P2 Up. But "rup" is a valid input on GameCube and Switch, so it should parse as "P1 Rup" assuming the player is assigned to the left side. If the player still wants to direct the input, they can use "rrup" or "r.rup" or "r:rup". "r.up" is similarly not a valid input for any system, so it should be parsed as "P2 Up".