Error on z80.js Line 669

Two9A / jsGB

JavaScript emulation of the GameBoy console

http://imrannazar.com/

Other

726 stars 110 forks source link

Open pmcanseco opened 8 years ago

pmcanseco commented 8 years ago

In z80.js line 669, the opcode 0x08 is mapped to a function "LDmmSP" which doesn't exist. https://github.com/Two9A/jsGB/blob/master/js/z80.js#L669

sjl commented 7 years ago

This may be a copy/paste error, possibly related to the two unused functions LDHLmm and LDmmHL, because:

I can't seem to find anything in the Gameboy Z80 manual about a LD (immediate), HL instruction.
The manual describes a LD (immediate), SP instruction with opcode 0x08, which corresponds to your missing instruction.

I think he copy/pasted something and meant to turn LDmmHL into LDmmSP, but just forgot.

Akhil841 commented 2 years ago

Addressed in this issue