search

TwoAbove / noita-tools

A collection of tools for Nolla Game's Noita that help get insight into seeds and find ones with special constraints.
https://www.noitool.com/
MIT License
58 stars 8 forks source link

Suggestion - Show fungal shifts past the first 20 #395

Open Exerlin opened 1 month ago

Exerlin commented 1 month ago

Is your feature request related to a problem? Please describe. You can only successfully fungal shift in a world 20 times. This does not include shifts that are skipped by trying to shift a material into itself. Noitool only shows the first 20 shifts for any given seed, so if any shifts are skipped, you will not have information about your last shifts.

Describe the solution you'd like I would like to be able to see shifts past the initial 20. A red line underneath the 20th shift would be useful so that you wouldn't have to count 20 shifts manually, and a button below that red line to "view additional shift" would help avoid adding more clutter to the webpage.

Describe alternatives you've considered Any way to view more fungal shifts would work. Adding an option in the settings to set the number of fungal shifts shown would be great too. A little + button at the bottom of the shifts list that adds 1 more shift to the list would also be great.

Additional context There is a lot of fun to be had via precise fungal shifting, and this additional knowledge would allow for MUCH more fungal shenanigans!

TwoAbove commented 1 month ago

Hey! I don't think that we can go over 20 fungal shifts? If I remember correctly, you can only have up to 20 fungal shifts in a given game.

If you look at data/scripts/magic/fungal_shift.lua:131, it's capped at 20. And the fungal logic in noitool src/services/SeedInfo/infoHandler/InfoProviders/FungalShift/fungal.cpp also does the same thing.

Exerlin commented 1 month ago

You can't perform more than 20 fungal shifts, but you can skip a shift on the table by trying to shift a material into itself. This triggers the next shift and only counts as 1 shift. It is only 1 of the possible 20 shifts the player can perform, but it is 2 of the listed shifts on Noitool. After skipping a shift and shifting 18 more times, you will still be able to shift 1 more time, but you would have reached the bottom of the list on Noitool. I have done it before, and it is a little frustrating.

I can't find data/scripts/magic/fungal_shift.lua:131. I'm not much of a dev, I just play the game, sorry.

Exerlin commented 1 month ago

I did test this a while ago, and I decided to try to reproduce my results today. However, trying to shift Lava into Lava resulted in Blood turning into Silver. It didn't skip it, and the next 2 shifts proceeded as normal. I'm thrown off as this goes against what I know and observed several months ago, even more so since Blood -> Silver is not listed on the seed's shift chart at all! I think this is a much more complicated issue than I thought it was when I made this suggestion.

Seed: 1816098421

TwoAbove commented 1 month ago

Oh, I see what you mean now! Thanks for explaining that.

Okay, so here's my idea for tackling this:

We can look for cases where the shift would result in the same material. For each of these instances, we'll add a new row. It's a finite number of extra rows, so it shouldn't get out of hand.

Sure, there might be some edge case where you end up with a bunch of these self-shifting scenarios, but in normal circumstances, it shouldn't add too many rows.

I'll experiment with how I can approach this.

This is great, thanks!

TwoAbove commented 1 month ago

Ah, thanks for testing. I'll test myself to see what happens after the 20 shifts