search

TwoWheelDev / gns3-converter

GNS3 Topology Converter
GNU General Public License v3.0
14 stars 13 forks source link

Make cx_Freeze optional #24

Closed boenrobot closed 9 years ago

boenrobot commented 9 years ago

gns3-converter is used as a dependency for GNS3-gui... I realize the importance of having a separate exe in production, but during development, this unnecessarily forces the user to install cx_Freeze beforehand.

This PR makes exe file creation be skipped with a warning if cx_Freeze is not found, allowing for gns3-gui installation to run uninterrupted.

As a "bonus feature", it adds windows specific stuff conditionally, while running one setup() call at the end, thus DRY-ing up the code... The Windows metadata was outdated anyway.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 52.84% when pulling 88977d5ad02d0dbacaa3dfa5e329d489195f73e6 on boenrobot:optionalCxFreeze into 6fe9eef1c21d5611069fa5485826b73e36714234 on dlintott:master.