Ty-stan0417 / pe

0 stars 0 forks source link

Can have person that with all attributes same, and same name (although case sensitive) #3

Open Ty-stan0417 opened 5 months ago

Ty-stan0417 commented 5 months ago

image.png

Referred to 1 and 3.

I can add two John Doe with the same name (although case sensitive) with all other attributes the same. This shouldn't be the case as in the real world names are not case sensitive and the app should have followed that.

nus-pe-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplication detection of contacts: Check names without case sensitivity

The three john doe in the screenshot actually have the totally same contact information. However, this kind of duplication is allowed in the app. There should be an error or at least a warning before I want to add quite similar contact information, because it's quite likely that these three people are actually 1 person. Screenshot 2024-04-19 at 4.53.49 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#5550] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Rejected - we allow similar names for flexibility

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** It's reasonable to consider them as referring to the same person. The difference in capitalization likely arose due to a typographical error or inconsistency in data entry. Moreover, please referred to CS2103T website. The website has said is likely the same person and considered as a bug. ![image.png](https://raw.githubusercontent.com/Ty-stan0417/pe/main/files/05574fca-1559-40e8-92bc-5375543b7fd6.png)