search

TycheSoftwares / custom-order-numbers-for-woocommerce

This repository is for the Custom Order Numbers for WooCommerce- Lite
2 stars 2 forks source link

Critical error message comes when users have a large number orders & the plugin tries to update them. #60

Closed apeksha10 closed 1 year ago

apeksha10 commented 3 years ago

Describe the bug Critical error message comes when users have a large number of orders & the plugin tries to update them.

To Reproduce Steps to reproduce the behavior:

  1. On woo_apeksha, I have 21000 plus past orders
  2. Take the latest git copy
  3. Go to the plugin setting page, try to change the prefix
  4. When I try to save that setting, the plugin throws me a critical error.

see the screenshot: https://www.screencast.com/t/TdzCNwr13M6e

Expected behavior No critical error message should appear.

ashokrane commented 2 years ago

@apeksha10 I don't think there would be a real use case where a store that has 21000+ orders would want to update all the past orders too with the prefix/suffix. To avoid this, we should add the option of "Select orders to apply new settings to" to the Lite version too (which is already added in Pro). What do you think?

@upenkapse Please share your thoughts too.

apeksha10 commented 2 years ago

@apeksha10 I don't think there would be a real use case where a store that has 21000+ orders would want to update all the past orders too with the prefix/suffix. To avoid this, we should add the option of "Select orders to apply new settings to" to the Lite version too (which is already added in Pro). What do you think?

That is good idea.

mital-tyche commented 1 year ago

Need to process based on batch wise in pro & lite both version. Hence I open this issue