Moved toasts to top-center & changed duration to 1 sec

Tychobra / polished

Authentication and Administration for Shiny apps

https://polished.tech

Other

234 stars 36 forks source link

Moved toasts to top-center & changed duration to 1 sec #107

Closed phoward38 closed 3 years ago

phoward38 commented 3 years ago

Are you getting these notes from devtools::check:

> checking package dependencies ... NOTE
  Imports includes 22 non-default packages.
  Importing from so many packages makes the package vulnerable to any of
  them becoming unavailable.  Move as many as possible to Suggests and
  use conditionally.

> checking for future file timestamps ... NOTE
  unable to verify current time

phoward38 commented 3 years ago

@merlinoa

I was thinking the same but wasn't sure where to put the toast options
Yea I tested it. Our show duration is 0.3 seconds by default in showToast

merlinoa commented 3 years ago

You can put the toast options in "utils.R". Use @noRd and don't export them.

It seemed like our prior default was a lot longer than 0.3 seconds, but I guess it was the fadein and fadeout time. Anyways update the toast options and I'll check it out real quick. Thanks.

merlinoa commented 3 years ago

Awesome! looks good.