search

Tychobra / polished

Authentication and Administration for Shiny apps
https://polished.tech
Other
234 stars 36 forks source link

Don't need the polished YAML argument #168

Closed muschellij2 closed 2 years ago

muschellij2 commented 2 years ago

The checks in secure_rmd are sufficient to fail without polished in the YAML header. For example:

secure_rmd(system.file("examples/rmds/flexdashboard.Rmd", package = "polished"))
secure_rmd(system.file("examples/rmds/flexdashboard.Rmd", package = "polished"),   global_sessions_config_args = list(
    api_key = get_api_key(),
app_name = "another_name"
  ))
muschellij2 commented 2 years ago

I think that should do it

muschellij2 commented 2 years ago

This shoudl be resolved now for both.

merlinoa commented 2 years ago

Awesome, LGTM -- merging now!