Tyderf / ForbiddenIsland

0 stars 0 forks source link

Refactor the Objects #3

Open joe-crick opened 6 years ago

joe-crick commented 6 years ago

@Tyderf, most of the cards are quite similar. Maybe rather than having different classes for each of the cards, we can have one Card class with Types. I created a CardType enum, and added it to the Card class.

I notice, too, that we have Tiles but no concept of a Board---i.e., a configuration of tiles in relation to each other. We should think about mapping out the relationship between the different data types we have, and how they influence each other.

We should also think about the concept of a Turn, and how that will work.

Tyderf commented 6 years ago

How do I make different types of cards with one class?

On 2018-06-30 23:55, Joe Crick wrote:

@Tyderf [1], most of the cards are quite similar. Maybe rather than having different classes for each of the cards, we can have one Card class with Types. I created a CardType enum, and added it to the Card class.

I notice, too, that we have Tiles but no concept of a Board---i.e., a configuration of tiles in relation to each other. We should think about mapping out the relationship between the different data types we have, and how they influence each other.

We should also think about the concept of a Turn, and how that will work.

-- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [2], or mute the thread [3].

Links:

[1] https://github.com/Tyderf [2] https://github.com/Tyderf/ForbiddenIsland/issues/3 [3] https://github.com/notifications/unsubscribe-auth/ANyQfn2X2gU8roeSXlrGHwbfQfq37MV1ks5uCHJVgaJpZM4U-OP0

joe-crick commented 6 years ago

@Tyderf, please @ reference me when you want to message me through github. I don't get emails otherwise, and it makes it hard to get back to you.

The Card object has:

Examples:

Waters Rise Card

Treasure Card

Helicopter Lift

Tyderf commented 6 years ago

@joe-crick Can you teach me what that means on Monday I don't know what enum is.