Tyelab / bruker_control

Repository for code running the lab's multi-photon imaging experiments at the Bruker Ultima Investigator scope. Unites Arduino, Prairie View, and GenTL machine cameras in Python.
Mozilla Public License 2.0
8 stars 3 forks source link

ITI Values (Maybe Trial Order) Is Wrong - Severe Bug #156

Closed jmdelahanty closed 1 year ago

jmdelahanty commented 1 year ago

The ITI Values configured in the .json file do not match even closely the values they're supposed to when looking at the output data. The .json files are likely completely useless and inaccurate in who knows how many other ways.

There must be something in the Arduino code that has problems with being stuck in the ITI state for some reason

This means that there are potentially other issues in the configuration values and potentially even trial structures that are executed by the scripts.

This would additionally mean none of the purported metadata included in the configuration can be counted on for anything either.

Before the next set of LH experiments for Jim this needs to be solved. That this has possibly been happening for who knows how long is unacceptable... Again, this code base should be abandoned and no future project should rely on it.

jmdelahanty commented 1 year ago

Trial orders do not appear to ever be wrong, it's a problem with timings either being calculated or ignored in the Arduino code.

jmdelahanty commented 1 year ago

It looks like there is a small amount of jitter, on the order of 10-20 ms (which isn't great) but it's never actually that wrong. My initial script looking at problems had a very simple bug in it so I didn't account for tones properly. This issue can be closed.