TT-12112 Add the value annotations to tyk-stack and component helm charts

mgnisia commented 5 months ago

Description

Add annotations variable to the values.yaml file of all relevant helm charts

Related Issue

Motivation and Context

To support an automated reloading of the gateway or other components of the tyk stack a common approach is to utilize tools like reloader. Currently the helm charts don't support any kind of annotations on the deployment level.

Test Coverage For This Change

I have been templating the helm charts on my machine (helm template) with:

annotations: {}

annotations:
  app: "someAnnotation"

The templating worked without any issues.

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)
[ ] Documentation updates or improvements.

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
[ ] Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
[ ] My change requires a change to the documentation.
- [ ] I have manually updated the README(s)/documentation accordingly.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

caroltyk commented 5 months ago

Thank you @mgnisia for your contribution. We will review this shortly.

mgnisia commented 4 months ago

@caroltyk Hi Carol, could you maybe take another look? that would be awesome.

caroltyk commented 4 months ago

Hi @mgnisia The PR looks good to me but I'll pass this to the engineers and QA for testing first. Let me update here when it is planned for release.

mgnisia commented 4 months ago

Thanks for the update 🙂 will revert the version change beginning of next week 👍🏻

mgnisia commented 3 months ago

Good morning @buraksekili revert the changes. It would be awesome if you cloud take another look. 👀

bojantyk commented 3 months ago

LGTM! @buraksekili we should proceed with merging this PR Thanks,

mgnisia commented 3 months ago

@buraksekili can you foresee when this PR will be merged?

buraksekili commented 3 months ago

@mgnisia thanks for your contribution 🏅 your contribution is going to be released within the next release.

TykTechnologies / tyk-charts