search

TykTechnologies / tyk-demo

Tyk Docker Demo with full Pro Tyk Installation and more!
52 stars 12 forks source link

defect: scripts/export.sh modifies API Definitions #218

Closed asoorm closed 11 months ago

asoorm commented 12 months ago

Step 1: Create a new API Step 2: run scripts/export.sh Step 3: run git status

Screenshot 2023-10-04 at 15 03 03

Step 4: run git diff on the changed files

4 API definitions are affected:

2 API Definitions, the issue appears to be a non-idempotent API ID.

Screenshot 2023-10-04 at 15 08 52

2 API Definitions, the issue appears to be the order of fields in the analytics_plugin object

Screenshot 2023-10-04 at 15 08 13

davegarvey commented 11 months ago

The issue with the webhook ids is due to their random nature. They can't be controlled, so change every time the API is imported, so will show as modifications when you export. You can either commit the change or revert, either is fine and makes no difference to the functionality.

For the field ordering, I'm not sure what's causing it, but it's likely outside of the export script's control. Like the webhook issue, I think it's fine to either commit or revert.