TykTechnologies / tyk-demo

Tyk Docker Demo with full Pro Tyk Installation and more!
51 stars 12 forks source link

Add openssl as a requirement to README #221

Closed letzya closed 5 months ago

davegarvey commented 8 months ago

Thanks for the PR @letzya, but I'm not sure that this is required anymore.

The script used to use the local openssl binary, but this ended up causing problems due to the variations that could occur, so it was changed to use the openssl from within the Gateway container.

You can see an example of this here, where the openssl command is executed within the Gateway container using a docker exec command:

docker exec -d $(get_service_container_id tyk-gateway) sh -c "openssl req -x509 -newkey rsa:4096 -subj \"/CN=tyk-gateway-2.localhost\" -keyout certs/tls-private-key.pem -out certs/tls-certificate.pem -days 365 -nodes" >>logs/bootstrap.log
letzya commented 8 months ago

I thought I saw it in the common script, Anyway, it was necessary on the day I opened it since it gave @asoorm an error on hi fresh new tyk-demo installation

davegarvey commented 8 months ago

Ok, interesting. Let's keep this open then, to understand what happened with the error. Thanks

On Tue, 24 Oct 2023, 12:01 Yaara, @.***> wrote:

I thought I saw it in the common script, Anyway, it was necessary on the day I opened it since it gave @asoorm https://github.com/asoorm an error on hi fresh new tyk-demo installation

— Reply to this email directly, view it on GitHub https://github.com/TykTechnologies/tyk-demo/pull/221#issuecomment-1776901784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANB2OZ4RUUUYMC2EESWWVTYA6GYBAVCNFSM6AAAAAA52X56N2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWHEYDCNZYGQ . You are receiving this because you were assigned.Message ID: @.***>

davegarvey commented 8 months ago

@asoorm would be good to know more about the issue you faced

letzya commented 5 months ago

closing it for now