search

TykTechnologies / tyk-gateway-docker

Docker compose deployment to run Tyk OSS Gateway
96 stars 80 forks source link

Synced the value of TYK_GW_SECRET with tyk.standlone.conf #52

Closed padmaraj85 closed 2 years ago

padmaraj85 commented 3 years ago

The value of TYK_GW_SECRET is now in sync with the value in the tyk.standalone.conf.

Reason: Anyone new to Tyk, following our docs on tyk-oss installation, will know about this. This creates an issue while trying to publish changes while following the below doc link. https://tyk.io/docs/getting-started/create-api/

Here is a thread related to the issue.

https://stackoverflow.com/questions/68155402/tyk-io-attempted-administrative-access-with-invalid-or-missing-key

davegarvey commented 3 years ago

I see why you've done this, but I think this requires wider input from the team.

The secret was most likely set to foo to prompt people to change it, as leaving it as the default presents a security risk.

padmaraj85 commented 3 years ago

Hi Dave, I agree with you. But , I believe, in here the value is set to foo because it's the same in tyk.hybrid.conf

Otherwise, we can update the document to refer to TYK_GW_SECRET and avoid this pull request.

davegarvey commented 3 years ago

So should the tyk.hybrid.conf be updated too?

alephnull commented 3 years ago

We would really like to deprecate this repo. Are there any objections?

davegarvey commented 3 years ago

We would really like to deprecate this repo. Are there any objections?

ok with me

padmaraj85 commented 3 years ago

Hi Alok,

You mean this branch correct? In that case, am fine too.

On Thu, Sep 30, 2021 at 12:09 PM David Garvey @.***> wrote:

We would really like to deprecate this repo. Are there any objections?

ok with me

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TykTechnologies/tyk-gateway-docker/pull/52#issuecomment-930855975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJGC5RA3KRWGPDJS5YG7I4TUEQA2DANCNFSM47PG6NAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.