govet TIB and gofmt-goimport

[sredxny]

Description

Related Issue

TT-106886

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

• [ ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own fork, don't request your master!
• [ ] Make sure you are making a pull request against the master branch (left side). Also, you should start your branch off our latest master.
• [ ] My change requires a change to the documentation.
  • [ ] If you've changed APIs, describe what needs to be updated in the documentation.
  • [ ] If new config option added, ensure that it can be set via ENV variable
• [ ] I have updated the documentation accordingly.
• [ ] Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
• [ ] When updating library version must provide reason/explanation for this update.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.
• [ ] Check your code additions will not fail linting checks:
  • [ ] go fmt -s
  • [ ] go vet

[sweep-ai[bot]]

Apply Sweep Rules to your PR?

• [ ] Apply: All new business logic should have corresponding unit tests.
• [ ] Apply: Refactor large functions to be more modular.
• [ ] Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

[github-actions[bot]]

Terraform Format and Style 🖌``

Terraform Initialization ⚙️success

Terraform Plan 📖success

Terraform Validation 🤖success

Show Plan

``` terraform Running plan in the remote backend. Output will stream here. Pressing Ctrl-C will stop streaming the logs, but will not stop the plan running remotely. Preparing the remote plan... To view this run in a browser, visit: https://app.terraform.io/app/Tyk/repo-policy-tyk-identity-broker/runs/run-ah1zpm9g2MTUyJM5 Waiting for the plan to start... Terraform v1.4.6 on linux_amd64 Initializing plugins and modules... module.tyk-identity-broker.github_repository.repository: Refreshing state... [id=tyk-identity-broker] module.tyk-identity-broker.github_branch.default: Refreshing state... [id=tyk-identity-broker:master] module.tyk-identity-broker.github_branch.release_branches["release-1.3"]: Refreshing state... [id=tyk-identity-broker:release-1.3] module.tyk-identity-broker.github_branch.release_branches["release-1.2"]: Refreshing state... [id=tyk-identity-broker:release-1.2] module.tyk-identity-broker.github_branch.release_branches["release-1.4"]: Refreshing state... [id=tyk-identity-broker:release-1.4] module.tyk-identity-broker.github_branch.release_branches["master"]: Refreshing state... [id=tyk-identity-broker:master] module.tyk-identity-broker.github_branch_protection.automerge["release-1.4"]: Refreshing state... [id=BPR_kwDOAtnrYs4CHTEd] module.tyk-identity-broker.github_branch_protection.automerge["master"]: Refreshing state... [id=MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMTUzMTE5Nzc=] module.tyk-identity-broker.github_branch_protection.automerge["release-1.2"]: Refreshing state... [id=BPR_kwDOAtnrYs4B_GQp] module.tyk-identity-broker.github_branch_protection.automerge["release-1.3"]: Refreshing state... [id=BPR_kwDOAtnrYs4B_GQn] module.tyk-identity-broker.github_branch_default.default: Refreshing state... [id=tyk-identity-broker] Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # module.tyk-identity-broker.github_branch_protection.automerge["master"] will be updated in-place ~ resource "github_branch_protection" "automerge" { id = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMTUzMTE5Nzc=" # (11 unchanged attributes hidden) ~ required_status_checks { ~ contexts = [ + "ci-test", # (1 unchanged element hidden) ] # (1 unchanged attribute hidden) } # (1 unchanged block hidden) } # module.tyk-identity-broker.github_branch_protection.automerge["release-1.4"] will be updated in-place ~ resource "github_branch_protection" "automerge" { id = "BPR_kwDOAtnrYs4CHTEd" # (11 unchanged attributes hidden) ~ required_status_checks { ~ contexts = [ + "ci-test", # (1 unchanged element hidden) ] # (1 unchanged attribute hidden) } # (1 unchanged block hidden) } Plan: 0 to add, 2 to change, 0 to destroy. ```

Pushed by: @sredxny, Action: pull_request

[github-actions[bot]]

Terraform Format and Style 🖌``

Terraform Initialization ⚙️success

Terraform Plan 📖success

Terraform Validation 🤖success

Show Plan

``` terraform Running plan in the remote backend. Output will stream here. Pressing Ctrl-C will stop streaming the logs, but will not stop the plan running remotely. Preparing the remote plan... To view this run in a browser, visit: https://app.terraform.io/app/Tyk/repo-policy-tyk-identity-broker/runs/run-5ZSRP8DHT3tLuKci Waiting for the plan to start... Terraform v1.4.6 on linux_amd64 Initializing plugins and modules... module.tyk-identity-broker.github_repository.repository: Refreshing state... [id=tyk-identity-broker] module.tyk-identity-broker.github_branch.default: Refreshing state... [id=tyk-identity-broker:master] module.tyk-identity-broker.github_branch.release_branches["release-1.2"]: Refreshing state... [id=tyk-identity-broker:release-1.2] module.tyk-identity-broker.github_branch.release_branches["master"]: Refreshing state... [id=tyk-identity-broker:master] module.tyk-identity-broker.github_branch_protection.automerge["release-1.3"]: Refreshing state... [id=BPR_kwDOAtnrYs4B_GQn] module.tyk-identity-broker.github_branch.release_branches["release-1.3"]: Refreshing state... [id=tyk-identity-broker:release-1.3] module.tyk-identity-broker.github_branch.release_branches["release-1.4"]: Refreshing state... [id=tyk-identity-broker:release-1.4] module.tyk-identity-broker.github_branch_protection.automerge["release-1.2"]: Refreshing state... [id=BPR_kwDOAtnrYs4B_GQp] module.tyk-identity-broker.github_branch_protection.automerge["release-1.4"]: Refreshing state... [id=BPR_kwDOAtnrYs4CHTEd] module.tyk-identity-broker.github_branch_protection.automerge["master"]: Refreshing state... [id=MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMTUzMTE5Nzc=] module.tyk-identity-broker.github_branch_default.default: Refreshing state... [id=tyk-identity-broker] Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # module.tyk-identity-broker.github_branch_protection.automerge["master"] will be updated in-place ~ resource "github_branch_protection" "automerge" { id = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMTUzMTE5Nzc=" # (11 unchanged attributes hidden) ~ required_status_checks { ~ contexts = [ + "ci-test", # (1 unchanged element hidden) ] # (1 unchanged attribute hidden) } # (1 unchanged block hidden) } # module.tyk-identity-broker.github_branch_protection.automerge["release-1.4"] will be updated in-place ~ resource "github_branch_protection" "automerge" { id = "BPR_kwDOAtnrYs4CHTEd" # (11 unchanged attributes hidden) ~ required_status_checks { ~ contexts = [ + "ci-test", # (1 unchanged element hidden) ] # (1 unchanged attribute hidden) } # (1 unchanged block hidden) } Plan: 0 to add, 2 to change, 0 to destroy. ```

Pushed by: @sredxny, Action: pull_request

[sonarcloud[bot]]

Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud