TykTechnologies / tyk

Tyk Open Source API Gateway written in Go, supporting REST, GraphQL, TCP and gRPC protocols
Other
9.7k stars 1.09k forks source link

[TT-12425] update gorilla/websocket #6361

Closed jeffy-mathew closed 4 months ago

jeffy-mathew commented 4 months ago

User description

Description

update gorilla/websocket

Related Issue

https://tyktech.atlassian.net/browse/TT-12425

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

Checklist


PR Type

dependencies


Description


Changes walkthrough ๐Ÿ“

Relevant files
Dependencies
go.mod
Update gorilla/websocket dependency version in go.mod       

go.mod
  • Updated github.com/gorilla/websocket dependency from v1.5.2 to v1.5.3.

  • +1/-1     
    go.sum
    Update checksum for gorilla/websocket in go.sum                   

    go.sum
  • Updated checksum entries for github.com/gorilla/websocket to reflect
    version change from v1.5.2 to v1.5.3.
  • +2/-2     

    ๐Ÿ’ก PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    github-actions[bot] commented 4 months ago

    PR Reviewer Guide ๐Ÿ”

    โฑ๏ธ Estimated effort to review [1-5] 1
    ๐Ÿงช Relevant tests No
    ๐Ÿ”’ Security concerns No
    โšก Key issues to review None
    github-actions[bot] commented 4 months ago

    API Changes

    no api changes detected
    github-actions[bot] commented 4 months ago

    PR Code Suggestions โœจ

    CategorySuggestion                                                                                                                                    Score
    Security
    Ensure the integrity and correctness of the new module checksums ___ **Confirm that the checksums for github.com/gorilla/websocket v1.5.3 are correct by
    verifying them against an official source or by running go mod tidy to ensure the
    integrity of the module.** [go.sum [304-305]](https://github.com/TykTechnologies/tyk/pull/6361/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63R304-R305) ```diff +github.com/gorilla/websocket v1.5.3 h1:saDtZ6Pbx/0u+bgYQ3q96pZgCzfhKXGPqt7kZ72aNNg= +github.com/gorilla/websocket v1.5.3/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE= - ```
    Suggestion importance[1-10]: 9 Why: Verifying the integrity of module checksums is essential for security and reliability. This suggestion addresses a critical aspect of dependency management and helps prevent issues related to tampered or corrupted modules.
    9
    Possible issue
    Verify compatibility and absence of breaking changes with the updated library version ___ **Ensure that the updated version of github.com/gorilla/websocket is compatible with other
    dependencies and does not introduce breaking changes. It's recommended to run integration
    tests and check the release notes of the library for potential breaking changes or new
    features that might affect the current project.** [go.mod [41]](https://github.com/TykTechnologies/tyk/pull/6361/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R41-R41) ```diff +github.com/gorilla/websocket v1.5.3 - ```
    Suggestion importance[1-10]: 8 Why: Ensuring compatibility and checking for breaking changes when updating a library version is crucial to maintain the stability of the project. This suggestion is important for preventing potential issues that could arise from the update.
    8
    github-actions[bot] commented 4 months ago

    :boom: CI tests failed :see_no_evil:

    git-state

    all ok

    Please look at the run or in the Checks tab.