[SYSE-370 master] June template application

[ermirizio]

User description

• [x] Images not being pushed to dockerhub on tag when distroless feature is missing
• [x] Policy match fix
• [x] Fix github ref name for test-controller ui on push trigger
• [x] Test controller UI missing conf for push event and other missconfigs
• [x] Test controller UI duplicated lines under pump & sink
• [ ] Quality gates for tyk-analitycs UI and API regression tests
• [x] release-5.3 is not treated correctly in test-controller logic
• [ ] Implement custom rules for enterprise artifacts in package promotion
• [x] Test controller UI
• [x] Accomodate templates for new controller UI
• [x] Add mongo7 and redis7 with cache_DB config field

---

PR Type

enhancement, bug fix

---

Description

• Refactored the inline script in .github/workflows/release.yml to use multiline YAML syntax for better readability and maintainability.
• Fixed the policy match command to correctly handle Docker tags and environment variables.
• Added grouping and echo statements to improve logging and debugging during the workflow execution.

---

Changes walkthrough 📝

	Relevant files
Enhancement	release.yml Refactor and fix release workflow script for Docker and policy matching .github/workflows/release.yml Refactored inline script to use multiline YAML syntax for better readability. Fixed the policy match command to correctly handle Docker tags and environment variables. Added grouping and echo statements for better logging and debugging. +21/-1

---

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions[bot]]

API Changes

no api changes detected

[github-actions[bot]]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review **Possible Bug:** The refactoring of the script in `.github/workflows/release.yml` has improved readability but it's crucial to ensure that the multiline format does not introduce any syntactical errors or misinterpretations, especially with the use of environment variables and command sequences. **Configuration Management:** The changes involve critical configuration files and scripts that control deployment and testing environments. It's important to verify that these changes align with the intended deployment workflows and do not disrupt existing functionalities.

[github-actions[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Security	Ensure environment variables are quoted in shell commands to prevent script injection ___ **To avoid potential script injection or execution errors, ensure that environment variables are properly quoted in shell commands.** [.github/workflows/release.yml [285]](https://github.com/TykTechnologies/tyk/pull/6410/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R285-R285) ```diff -match_tag=${{steps.ecr.outputs.registry}}/$REPO:$BASE_REF +match_tag="${{steps.ecr.outputs.registry}}/$REPO:$BASE_REF" ``` Suggestion importance[1-10]: 9 Why: Quoting environment variables in shell commands is a crucial security measure to prevent script injection and execution errors, making this a highly valuable suggestion.	9
Best practice	Use absolute paths for Docker volume mounts to ensure consistent behavior across different environments ___ **It is recommended to use absolute paths for volume mounts in Docker commands to avoid potential issues with relative paths, which might not behave as expected in different execution environments.** [.github/workflows/release.yml [287]](https://github.com/TykTechnologies/tyk/pull/6410/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R287-R287) ```diff -docker run -q --rm -v ~/.docker/config.json:/root/.docker/config.json tykio/gromit policy match ${tags[0]} ${match_tag} 2>versions.env +docker run -q --rm -v ${{ github.workspace }}/.docker/config.json:/root/.docker/config.json tykio/gromit policy match ${tags[0]} ${match_tag} 2>versions.env ``` Suggestion importance[1-10]: 8 Why: Using absolute paths for Docker volume mounts is a best practice that ensures consistent behavior across different environments, which can prevent potential issues with relative paths.	8
Reliability	Add error handling or retry mechanisms to Docker commands to ensure reliability ___ **To ensure that Docker commands execute reliably, consider adding error handling or a retry mechanism in case of failures.** [.github/workflows/release.yml [302]](https://github.com/TykTechnologies/tyk/pull/6410/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R302-R302) ```diff -docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --env-file versions.env --profile master-datacenter up --quiet-pull -d +until docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --env-file versions.env --profile master-datacenter up --quiet-pull -d; do + echo "Trying again" + sleep 5 +done ``` Suggestion importance[1-10]: 7 Why: Adding error handling or retry mechanisms to Docker commands can significantly improve the reliability of the script, although it may add some complexity.	7
Maintainability	Use descriptive variable names to enhance code readability and maintainability ___ **Consider using a more descriptive variable name than tags to improve code readability and maintainability.** [.github/workflows/release.yml [286]](https://github.com/TykTechnologies/tyk/pull/6410/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R286-R286) ```diff -tags=(${{ needs.goreleaser.outputs.tags }}) +release_tags=(${{ needs.goreleaser.outputs.tags }}) ``` Suggestion importance[1-10]: 6 Why: Using more descriptive variable names improves code readability and maintainability, although this is a minor enhancement compared to functional or security improvements.	6

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud