[SYSE-370 master] June template application

[alephnull]

• [x] Fix github ref name for test-controller ui on push trigger
• [x] Test controller UI missing conf for push event and other missconfigs
• [x] Test controller UI duplicated lines under pump & sink
• [x] release-5.3 is not treated correctly in test-controller logic
• [x] Test controller UI
• [x] Accomodate templates for new controller UI
• [x] Add mongo7 and redis7 with cache_DB config field

[github-actions[bot]]

API Changes

no api changes detected

[github-actions[bot]]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Dependency Update The PR updates the Docker build-push-action from v5 to v6. It's important to ensure that all features and custom configurations used with v5 are compatible with v6 to avoid potential deployment issues. Code Consolidation The PR introduces changes to the docker compose commands and environment setup which could affect the existing setup. Review for potential impacts on the system's stability and performance is recommended. Test Coverage The modifications in the test execution commands and environment variables need thorough testing to ensure they do not affect the existing test outcomes and coverage.

[github-actions[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Add error handling for the docker run command to catch failures ___ **Add error handling for the docker run command to ensure that any failures in the container execution are caught and handled appropriately.** [.github/workflows/release.yml [308]](https://github.com/TykTechnologies/tyk/pull/6418/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R308-R308) ```diff -docker run --rm --network auto_default --env-file pytest.env -v ${{ github.workspace }}/reports:/app/reports ${{ steps.ecr.outputs.registry }}/tyk-automated-tests:$BASE_REF pytest -c pytest_ci.ini --junitxml=./${XUNIT_REPORT_PATH#"${{ github.workspace }}"} --ci -m "not local and not dind ${{ matrix.markers }}" | tee tests.out +if ! docker run --rm --network auto_default --env-file pytest.env -v ${{ github.workspace }}/reports:/app/reports ${{ steps.ecr.outputs.registry }}/tyk-automated-tests:$BASE_REF pytest -c pytest_ci.ini --junitxml=./${XUNIT_REPORT_PATH#"${{ github.workspace }}"} --ci -m "not local and not dind ${{ matrix.markers }}" | tee tests.out; then + echo "Docker run failed" >&2 + exit 1 +fi ``` Suggestion importance[1-10]: 9 Why: Adding error handling to the `docker run` command ensures that any failures in the container execution are caught and handled appropriately, improving the robustness of the workflow.	9
Enhancement	Update the Docker build-push action to the latest version for improved features and stability ___ **Update the docker/build-push-action to the latest version v10 instead of v6 to take advantage of the latest features and bug fixes.** [.github/workflows/release.yml [141]](https://github.com/TykTechnologies/tyk/pull/6418/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R141-R141) ```diff -uses: docker/build-push-action@v6 +uses: docker/build-push-action@v10 ``` Suggestion importance[1-10]: 8 Why: Updating to the latest version of the Docker build-push action can provide new features and bug fixes, improving the overall stability and functionality of the workflow. However, it is important to verify compatibility with the rest of the workflow.	8
Possible issue	Correct the placement of the --quiet-pull flag in the docker compose command for proper functionality ___ **Ensure that the docker compose command uses the correct syntax for the --quiet-pull flag, which should be placed before the up command for proper execution.** [.github/workflows/release.yml [299]](https://github.com/TykTechnologies/tyk/pull/6418/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R299-R299) ```diff -docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --env-file versions.env --profile master-datacenter up --quiet-pull -d +docker compose -p auto -f pro-ha.yml -f deps_pro-ha.yml -f ${{ matrix.envfiles.db }}.yml -f ${{ matrix.envfiles.cache }}.yml --quiet-pull --env-file versions.env --profile master-datacenter up -d ``` Suggestion importance[1-10]: 7 Why: The suggestion corrects the syntax of the `docker compose` command, ensuring that the `--quiet-pull` flag is placed correctly for proper execution. This improves the reliability of the command.	7

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud