TykTechnologies / tyk

Tyk Open Source API Gateway written in Go, supporting REST, GraphQL, TCP and gRPC protocols
Other
9.75k stars 1.09k forks source link

Unable to build locally due to missing redis/v9 revision v9.5.3 #6424

Open martinsirbe opened 4 months ago

martinsirbe commented 4 months ago

Do you want to request a feature or report a bug?

Bug

What is the current behaviour?

Building Tyk locally fails due to an issue with the redis/v9 revision not being found.

What is the expected behaviour?

The build process should complete successfully without errors related to the redis/v9 dependency.

If the current behaviour is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  1. Clone the Tyk repository.
  2. Run go mod.
  3. The following error occurs:
    go: github.com/TykTechnologies/tyk/internal/redis imports
        github.com/redis/go-redis/v9: reading github.com/redis/go-redis/go.mod at revision v9.5.3: unknown revision v9.5.3

Which versions of Tyk are affected by this issue? Did this work in previous versions of Tyk?

This issue is present in the latest version as referenced in this commit: https://github.com/TykTechnologies/tyk/blob/1c5a54c18dbd4e4a9074a27accd6501e440763fa/go.mod#L82

It is unclear if this issue existed in previous versions.

titpetric commented 4 months ago

I can't reproduce this (I asumed go mod download in step 2):

go: github.com/TykTechnologies/tyk/internal/redis imports
    github.com/redis/go-redis/v9:
        reading github.com/redis/go-redis/go.mod at revision v9.5.3:
        unknown revision v9.5.3

what is your go env, go version, could you provide reproduce steps demonstrating the issue?

titpetric commented 4 months ago

I've seen the upstream has added a go mod retraction and the git tag remains as the fallback. I don't think this is applicable anymore, and we'll be bumping to redis 9.6.1 for a future release. I'm leaving the issue open until that's done. Thank you for the heads up.