[TT-13122] build multiarch image on 1.22-bullseye

jeffy-mathew commented 2 months ago

Description

build multiarch image on 1.22-bullseye, currently the step is skipped with a typo from go 1.22 upgrade

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

[ ] I ensured that the documentation is up to date
[ ] I explained why this PR updates go.mod in detail with reasoning why it's required
[ ] I would like a code coverage CI quality gate exception and have explained why

configuration changes

Updated the GitHub Actions workflow to build a multiarch Docker image using golang_cross version 1.22-bullseye instead of 1.21-bullseye.
This change ensures that the build process aligns with the updated Go version requirements.

Relevant files

Configuration changes

release.yml

Update multiarch image build condition in release workflow

.github/workflows/release.yml

Updated the condition for building a multiarch image.

Changed the golang_cross version from 1.21-bullseye to 1.22-bullseye.

+1/-1

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

github-actions[bot] commented 2 months ago

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No key issues to review

github-actions[bot] commented 2 months ago

Category	Suggestion	Score
Maintainability	Use a more flexible condition to match any version starting with '1.' and ending with '-bullseye' ___ Consider using a more inclusive condition to allow for future versions without needing modifications. Instead of hardcoding the version, use a regular expression or a wildcard to match any version that starts with '1.' and ends with '-bullseye'. [.github/workflows/release.yml [174]](https://github.com/TykTechnologies/tyk/pull/6549/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R174-R174) ```diff -if: ${{ matrix.golang_cross == '1.22-bullseye' }} +if: ${{ startsWith(matrix.golang_cross, '1.') && endsWith(matrix.golang_cross, '-bullseye') }} ``` Suggestion importance[1-10]: 8 Why: The suggestion improves maintainability by allowing future versions to be matched without requiring code changes, which is beneficial for long-term flexibility and reduces the need for frequent updates.	8