Closed titpetric closed 4 weeks ago
Let's make that PR title a π― shall we? πͺ
<p>
Your <em>PR title</em> and <em>story title</em> look <strong>slightly different</strong>. Just checking in to know if it was intentional!
</p>
<table>
<tr>
<th>Story Title</th>
<td>[Plugin docs] Provide guidance on compiling plugins manually</td>
</tr>
<tr>
<th>PR Title</th>
<td>[TT-12885] Add plugin development guide for manual builds</td>
</tr>
</table>
<p>
Check out this <a href="https://www.atlassian.com/blog/git/written-unwritten-guide-pull-requests">guide</a> to learn more about PR best-practices.
</p>
Here are some key observations to aid the review process:
β±οΈ Estimated effort to review: 3 π΅π΅π΅βͺβͺ |
π§ͺ No relevant tests |
π No security concerns identified |
β‘ Recommended focus areas for review Documentation Clarity The documentation should clarify the use of specific Go versions and the necessity of matching these versions between the gateway and plugins to avoid compatibility issues. It's also recommended to provide more explicit steps or checks to ensure that developers follow these guidelines correctly. Error Handling The Taskfile commands for checking out repositories and building projects should include better error handling to ensure that any failures in these steps are caught and handled appropriately. This would prevent the continuation of the workflow in an erroneous state, which could lead to further complications. |
API Changes
no api changes detected
No code suggestions found for the PR.
@titpetric I would propose to build a plugin together with the steps, like a hello world plugin, that they can copy paste from the guidance and endup with a functional plugin
@titpetric I would propose to build a plugin together with the steps, like a hello world plugin, that they can copy paste from the guidance and endup with a functional plugin
I see that it uses CustomGoPlugin in the example, which is perfect.
Failed conditions
0.0% Coverage on New Code (required β₯ 80%)
User description
TT-12885
https://tyktech.atlassian.net/browse/TT-12885
PR Type
Documentation, Enhancement
Description
Changes walkthrough π
Taskfile.yml
Add Taskfile for markdown formatting with mdox
docs/Taskfile.yml
mdox
for formatting markdown files.Taskfile.yml
Add Taskfile for automating plugin development tasks
docs/plugins/Taskfile.yml
testing plugins.
README.md
Add comprehensive Go plugin development guide
docs/plugins/README.md
and testing plugins.
swagger.md
Fix indentation in swagger generation documentation
docs/swagger.md
files.