TT-13130 update gorpc version

sredxny commented 1 week ago

User description

Summary	Tyk Cloud: Panic appears when a user tried to deploy GW before Control Plane is in deployed state
Type	Bug
Status	In Dev
Points	N/A
Labels	Re_open, QA_Fail

Description

Related Issue

TT-13130

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

[ ] I ensured that the documentation is up to date
[ ] I explained why this PR updates go.mod in detail with reasoning why it's required
[ ] I would like a code coverage CI quality gate exception and have explained why

PR Type

Bug fix, Enhancement

Description

Updated the gorpc library to a newer version in go.mod and go.sum.
Modified the RPC client connection handling by replacing ConnectionDialingWG.Wait() with WaitForConnection(), improving the connection logic.

Changes walkthrough 📝

Relevant files

Enhancement

rpc_client.go

Update connection handling in RPC client

rpc/rpc_client.go

Replaced ConnectionDialingWG.Wait() with WaitForConnection().

Improved connection handling logic.

+1/-1

Dependencies

go.mod `Update gorpc dependency version in go.mod` go.mod - Updated `gorpc` dependency version.	+1/-1
go.sum `Update go.sum with new gorpc checksums` go.sum - Added new checksum entries for updated `gorpc` version.	+2/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

buger commented 1 week ago

Knock Knock! 🔍

Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR.

An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️

Story Title	Tyk Cloud: Panic appears when a user tried to deploy GW before Control Plane is in deployed state
PR Title	TT-13130 update gorpc version

Check out this guide to learn more about PR best-practices.

github-actions[bot] commented 1 week ago

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

API Change
The method `WaitForConnection` is used instead of `ConnectionDialingWG.Wait`. Ensure that the new method covers all intended functionality and does not introduce any side effects.

github-actions[bot] commented 1 week ago

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible bug	Prevent potential nil pointer dereference by checking if `clientSingleton` is not nil before calling `WaitForConnection()` ___ Replace the direct call to `clientSingleton.WaitForConnection()` with a conditional check to ensure `clientSingleton` is not nil before invoking `WaitForConnection()`. This prevents potential nil pointer dereference errors. [rpc/rpc_client.go [308]](https://github.com/TykTechnologies/tyk/pull/6644/files#diff-3b88914c99bb9418e44e6389ce73579843562e8900730b380d7fff2e95c51033R308-R308) ```diff -clientSingleton.WaitForConnection() +if clientSingleton != nil { + clientSingleton.WaitForConnection() +} ``` Suggestion importance[1-10]: 9 Why: The suggestion addresses a critical issue by preventing a potential nil pointer dereference, which could lead to runtime errors. Adding a nil check before calling `WaitForConnection()` ensures the code is more robust and prevents crashes.	9

github-actions[bot] commented 1 week ago

API Changes

no api changes detected

sonarcloud[bot] commented 1 week ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sredxny commented 1 week ago

/release to release-5.3