Closed sredxny closed 1 week ago
Knock Knock! ๐
Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR.
An easy-to-understand PR title a day makes the reviewer review away! ๐โก๏ธ
Story Title | Tyk Cloud: Panic appears when a user tried to deploy GW before Control Plane is in deployed state |
---|---|
PR Title | TT-13130 update gorpc version |
Check out this guide to learn more about PR best-practices.
Here are some key observations to aid the review process:
โฑ๏ธ Estimated effort to review: 2 ๐ต๐ตโชโชโช |
๐งช No relevant tests |
๐ No security concerns identified |
โก Recommended focus areas for review API Change The method `WaitForConnection` is used instead of `ConnectionDialingWG.Wait`. Ensure that the new method covers all intended functionality and does not introduce any side effects. |
Explore these optional code suggestions:
Category | Suggestion | Score |
Possible bug |
Prevent potential nil pointer dereference by checking if
___
**Replace the direct call to | 9 |
API Changes
no api changes detected
Failed conditions
0.0% Coverage on New Code (required โฅ 80%)
/release to release-5.3
Working on it! Note that it can take a few minutes.
/release to release-5.6.1
@sredxny Succesfully merged PR
Working on it! Note that it can take a few minutes.
@ilijabojanovic Succesfully merged PR
/release to release-5.3.7
Working on it! Note that it can take a few minutes.
@sredxny Succesfully merged PR
/release to release-5.6
Working on it! Note that it can take a few minutes.
@sredxny Succesfully merged PR
/release to release-5-lts
Working on it! Note that it can take a few minutes.
@sredxny Succesfully merged PR
User description
TT-13130
Description
Related Issue
TT-13130
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
gorpc
library to a newer version ingo.mod
andgo.sum
.ConnectionDialingWG.Wait()
withWaitForConnection()
, improving the connection logic.Changes walkthrough ๐
rpc_client.go
Update connection handling in RPC client
rpc/rpc_client.go
ConnectionDialingWG.Wait()
withWaitForConnection()
.go.mod
Update gorpc dependency version in go.mod
go.mod - Updated `gorpc` dependency version.
go.sum
Update go.sum with new gorpc checksums
go.sum - Added new checksum entries for updated `gorpc` version.