Tyler-Keith-Thompson / CucumberSwift

A lightweight swift Cucumber implementation
https://tyler-keith-thompson.github.io/CucumberSwift/documentation/cucumberswift/
MIT License
74 stars 19 forks source link

Empty cell in table error #86

Closed SurglogsGithubUser closed 1 year ago

SurglogsGithubUser commented 1 year ago

Describe the bug When there is no value in table, there is error mesages (and also it will fail tests). I think there is error with symbols < > (as mentioned here) and also with empty values Error messages:

XCTAssertTrue failed - Gherkin language errors found:
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found
File: entry.feature, table header <none> not found

Additional context Add any other context about the problem here.

    When  User clicks on "Temperature and Humidity Log" log
    And   User clicks on 'filter' menu item
    And   User clicks on "Show ignored" button
    And   User clicks on "Close" button
    Then  User should see log entries:
      | TYPE    | NAME       | SUMMARY              | LABEL     | ACTIONS |
      | missed  | 01/06/2021 | Missed check         |           | <none>  |
      | missed  | 01/05/2021 | Missed check         |           | <none>  |
      | checked | 01/04/2021 | Logged by Test user  |           | <none>  |
      | checked | 01/03/2021 | Logged by Test user  |           | <none>  |
      | ignored | 01/02/2021 | Ignored by Test user | (Ignored) | <none>  |
      | ignored | 01/01/2021 | Ignored by Test user | (Ignored) | <none>  |
    When  User clicks on "01/01/2021" entry
    Then  User should see "SL - Log entry" screen
    And   User should see "12:00 AM on Friday, January 01, 2021" text
    And   User should see "Logged by Test user" text
    And   User should see "Show Edit History" button
    And   User should see "Reason/Note" text
    And   User should see "Humidity indicator failure." text
    But   User should not see 'edit' menu item
Tyler-Keith-Thompson commented 1 year ago

Just to clarify there's 2 problems here. Once is that LABEL has empty values which aren't behaving as expected and additionally the ACTIONS of <none> are also erroring out?

I think I understand why this would happen. I'll take a look as soon as I can, but PRs are also welcome.

SurglogsGithubUser commented 1 year ago

Just to clarify there's 2 problems here. Once is that LABEL has empty values which aren't behaving as expected and additionally the ACTIONS of <none> are also erroring out?

I think I understand why this would happen. I'll take a look as soon as I can, but PRs are also welcome.

Correct

Tyler-Keith-Thompson commented 1 year ago

This should be resolved in CucumberSwift v4.2.2