Tyler2004 / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
1 stars 0 forks source link

Annotated PGN support #495

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I would very much enjoy the ability to load a game and then be able to
create variations (preferably more than one ... saveable, of course) at any
point (perhaps every move).  There are already conventions for this in
books (variations are given letters (6a, 22b, etc.)), and placed between
curly braces in PGN files.

For example, I play through a game in a book - which invariably come with
one or more variations which I'd like to play through.  Or maybe I load a
Crafty annotataion file, and would like to see Crafty's suggested lines.

Original issue reported on code.google.com by jokovelt...@gmail.com on 30 Sep 2009 at 10:13

GoogleCodeExporter commented 9 years ago
There is a "database" branch in svn with preliminary support for variations, at 
least
for PGN, and boardwidget, but no work started on creating variations with 
pychess yet.

Original comment by gbtami on 1 Oct 2009 at 8:55

GoogleCodeExporter commented 9 years ago

Original comment by gbtami on 20 Oct 2009 at 4:45

GoogleCodeExporter commented 9 years ago
Progress!
In gbtami-annotation-panel clone there is a more or less working implementation 
where you can move in the variations by clicking into them. You have to enable 
the new panel in the preferences menu first. Committed a sample annotated file 
too (testing/gamefiles/world_matches.pgn).
http://code.google.com/r/gbtami-annotation-panel/

Original comment by gbtami on 23 May 2011 at 7:33

GoogleCodeExporter commented 9 years ago
Today I merged the panel stuff to mainline. Please test it!
Notice, there is no add/delete/edit support implemented for comments/variations 
yet.

Original comment by gbtami on 26 Jun 2011 at 1:12

GoogleCodeExporter commented 9 years ago
Great stuff.

Here are a few things I found:
 * When a player changes name, the panel doesn't update. This can happen from the preferences window, but more importantly, the PyChess engine initially has an ugly "python - timestamp" name for fast initialization, which is changed once it tells us its real name.
 * The * star in the Name - Name header, doesn't change when the game finishes. I supposed it should turn into 1/0, 0/1 or similar.
 * If you are using FAN notation and a player checkmates, the last move gets displayed twice, both before and after the 0-1 mark.

Original comment by lobais on 29 Jun 2011 at 10:05

GoogleCodeExporter commented 9 years ago
On the first, there is actually no good way to do this now.
The way ionest does it is by

    if type == ARTIFICIAL:
        def readyformoves (player, color):
            updateTitle(color)
        players[i].connect("readyForMoves", readyformoves, i)

For engines and a conf connect for humans.

Original comment by lobais on 29 Jun 2011 at 10:47

GoogleCodeExporter commented 9 years ago
Awesome work Tamás!

Original comment by mattgatto on 2 Jul 2011 at 7:23

GoogleCodeExporter commented 9 years ago
Comment #5 bugs now fixed in tip.

Original comment by gbtami on 6 Jul 2011 at 9:45

GoogleCodeExporter commented 9 years ago
Implemented add/edit for comments. You can try it with left/right clicking on 
moves/comments. Any feedback are welcome!

Original comment by gbtami on 13 Jul 2011 at 12:29

GoogleCodeExporter commented 9 years ago
Cool, it works well for me. How would adding new comments work? Maybe an "Add" 
button on the bottom of the panel that brought up the same "Edit" dialog when 
you clicked on a move?

Original comment by mattgatto on 17 Jul 2011 at 11:46

GoogleCodeExporter commented 9 years ago
Right clicking on moves brings up a context menu containing "Add comment". I'm 
thinking on a new main menu item "Edit", but not sure about submenu items.
Maybe:
Initial game/variation comment
Move comments
Delete remaining moves
Edit game data
Copy to FEN
Paste from FEN

What are you think?

Original comment by gbtami on 17 Jul 2011 at 12:04

GoogleCodeExporter commented 9 years ago
TODO: Consider Christopher's suggestion in 
https://groups.google.com/forum/?fromgroups=#!searchin/pychess-people/nag/pyches
s-people/FrQXEk6wdfE/Ffx2eqU5t9EJ
Consider what symbols scidb use.

Original comment by gbtami on 8 Apr 2013 at 9:46

GoogleCodeExporter commented 9 years ago

Original comment by gbtami on 27 Jun 2013 at 10:08