When doing a 'rematch' against a failed engine, board is rotated although auto board rotate is off

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Complete a match against an engine that will end it with an invalid move (a 
regular game ending might also be possible, not tested)
2. Click "rematch"
3. (The engine also immediately did an invalid move here, playing white, but 
that is probably unrelated)

What is the expected output? What do you see instead?
Board is rotated, but "Auto rotate board to current player" wasn't ticked (see 
screenshot).
I expected it not to rotate: the board had standard white down, black up 
rotation before clicking "Rematch" and I didn't rotate it explicitely in any 
way.
When restarting pychess, it will start with white down, black up rotation again.

Happened each time I tested it

What version of the product are you using?
Tested both stable Staunton/10.1 and hg

Original issue reported on code.google.com by jonas.thiem@gmail.com on 4 Sep 2012 at 11:34

Attachments:

• 2012-09-05_01-25-26.log

[GoogleCodeExporter]

The screenshot which I forgot to attach

Original comment by jonas.thiem@gmail.com on 4 Sep 2012 at 11:35

Attachments:

• autorotate.png

[GoogleCodeExporter]

In fact I was confused, I thought the setting would affect the rotation of the 
board at game start aswell - but it only affects rotation after each move in a 
human vs human game.

So we need another option for rotating the board at game start towards the 
human player I guess. Or alternatively, I have been thinking, wouldn't it make 
sense to control both with this one? Probably, people would either like 
rotation and then assumably would want it always (both at game start and after 
a move in a human vs human game), or wouldn't like it like me and just would 
want their board in standard rotation no matter who's playing.

Original comment by jonas.thiem@gmail.com on 5 Sep 2012 at 8:52

[GoogleCodeExporter]

If we settle for two options, what about this:

Make a new preference section, like "Animation" on the screenshot named "Board 
auto-rotation", with those two options:
"Auto-rotate board to current human player at the start of the game"
"Auto-rotate board to current human player after every move in a two human 
players game"

When the first is disabled, the latter should probably be implicitely disabled 
aswell (both the setting and the checkbox to illustrate that).

My preferred setup is both disabled, btami seems to like first enabled, second 
disabled, and I suppose some people like both enabled.

Original comment by jonas.thiem@gmail.com on 5 Sep 2012 at 9:01

[GoogleCodeExporter]

Original comment by gbtami on 5 Sep 2012 at 9:04

• Changed state: Accepted
• Added labels: Type-Enhancement

[GoogleCodeExporter]

Or what about naming them:

"Auto-rotate board to human player at the start of games with one local human 
player"
"Auto-rotate board after every move in a game with two local human players"

Or is that too complicated? :-) (I added "local" to avoid confusion with FICS 
games)
Well, maybe the second one shouldn't be dependant on the first being enabled 
then, they seem to be for different game cases now as I think of it..

Original comment by jonas.thiem@gmail.com on 5 Sep 2012 at 9:06