search

Tyler799 / Morrowind-2020

An updated, revised and reformatted version of the Morrowind-YEAR series!
Other
154 stars 35 forks source link

Update Morrowind_2019.md #114

Closed generrosity closed 4 years ago

generrosity commented 5 years ago

Tweaking several things based on my experiances

Also may include some unintentional changes you made for INIs? I thought it should have merged those, but I'm not confused on what to exactly remove as there is more than I expected, sorry, hopefully an easy edit

Tyler799 commented 5 years ago

I appreciate some of the changes, but there are some concerns.

1: "Editor's notes" or suggestions or otherwise shouldn't be put into a pull request. Make those into issues. Only put things into a PR that should actually be in final, finished, everyone-sees-this guide.

Like the "Wayback empty link?" comment, or the "This is a OR alternative?" comment. Those can't be merged into the guide, it would look really sloppy.

Instead, make those sort of things into a github issue talking about what you're confused about, or what needs to change.

2: "Random other tips" isn't very professional for a title. Instead, I think it would be good to put that in the "testing" section.

3: "Note - do not enable grass mods in the launcher or MO2."

This isn't right from what I remember. The mods can and should be enabled. It's just the ESP's of those mods that shouldn't be enabled before running the distant land generator. (But I don't think it matters, I think the distant land generator has an option to choose what ESPs you want active) Once you've run it, they should be re-enabled. (IIRC, it's been awhile)

4; "Wayback empty link?" isn't empty for me, downloads fine. Also

5: "Search and Download either" - Don't need to search...it's right on the page that I linked to.

generrosity commented 5 years ago

Thanks. I will clean up the text, retest the links in another browser. and do some testing regards grass (I assumed the quoted text saying "again" but no initial note of it).

Thanks for your patience with my edits - so far been blown away at how difficult getting modded was, and how good a baseline this was. Cheers!