search

TylerBarnes / gatsby-plugin-transition-link

A link component for page transitions in gatsby
537 stars 70 forks source link

feat: added scroll feature to TransitionLink for navigating to hashed… #192

Closed yongkyali closed 4 years ago

yongkyali commented 4 years ago

… URL from same page

Because gatsby navigation won't work if scrolling through same page is not supported, samePageScroll props is added. samePageScroll will replace tag to conventional tag to emulate scrolling to desired url which contains tag.

If this get approved, I might continue developing the animation (smooth scrolling and other possible animation) before this PR get merged into master.

Please let me know if there's fix needed. Cheers!

TylerBarnes commented 4 years ago

Hi @yongkylie , I appreciate you taking the time to create this PR! Unfortunately I don't think this functionality belongs in this package. The sole responsibility of this package is to create transitions between pages, the code you added looks like it works great, but it belongs outside of the TransitionLink component.

Thanks again!