search

TylerBarnes / gatsby-plugin-transition-link

A link component for page transitions in gatsby
537 stars 71 forks source link

broken with Gatsby@2.24.70 #236

Closed y0hnn closed 3 years ago

y0hnn commented 3 years ago

Hey,

It seems something in Gatsby@2.24.70 broke the animations. Maybe related to https://github.com/gatsbyjs/gatsby/pull/27261 ?

joebentaylor1995 commented 3 years ago

Same here

riginosk commented 3 years ago

Same here, seems like trigger does not run at all. There is nothing logged in the console. exit={{ trigger: ({ node, e, exit, entry }) => console.log(node, e, exit, entry) // here node refers to the DOM node of the exiting page }}

aaadamgo commented 3 years ago

Yeah 100% broke for me yesterday when updating all my packages. Narrowed it down to the gatsby version. Running on 2.24.67 makes things work again. I was using a simple "cover" background color transition. Now, the colour being passed in was correct, but the swipe itself never used that colour. So although it didn't break animations, it definitely stopped doing what it was supposed to do.

joebentaylor1995 commented 3 years ago

For me all of my custom transitions totally broke and nothing fired same as @riginosk

TylerBarnes commented 3 years ago

Hey everyone, I think I have a fix for this. 🤞 might take me a little bit to release it but I'm working on it

TylerBarnes commented 3 years ago

Hey yall! I just published a fix in gatsby-plugin-transition-link@1.20.4! Let me know if you run into any problems with it :)

TylerBarnes commented 3 years ago

Update to gatsby-plugin-transition-link@1.20.5 because I broke builds in the last version 😆

joebentaylor1995 commented 3 years ago

FFS Tyler 🤦🏼‍♂️

Kind regards,

Joe

On 17 Oct 2020, at 18:33, Tyler Barnes notifications@github.com wrote:

 Update to gatsby-plugin-transition-link@1.20.5 because I broke builds in the last version 😆

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.