search

TylerBarnes / gatsby-wordpress-inline-images

Fluid images for gatsby-source-wordpress inline images in post_content
57 stars 25 forks source link

fix: original image with size #20

Closed rgllm closed 4 years ago

rgllm commented 4 years ago

@riencoertjens this fixes the issue discussed here https://github.com/TylerBarnes/gatsby-wordpress-inline-images/issues/15.

Please let me know if you have any question.

rgllm commented 4 years ago

Thanks so much for this! It looks great. Would you mind adding a couple comments as to why we have to do this and what the second download is for? I can also add them if you'd like, just don't want to mess with your PR :) Let me know

Done @TylerBarnes 👍

rgllm commented 4 years ago

@TylerBarnes any updates on this?

TylerBarnes commented 4 years ago

@rgllm apologies for the delay on this. I was on vacation and then was working super hard writing the new version of gatsby-source-wordpress! I joined the Gatsby core team recently. Heads up, when gatsby-source-wordpress@v4 drops, this package will be deprecated. See https://github.com/gatsbyjs/gatsby/issues/19292 for more info

TylerBarnes commented 4 years ago

Also, this is published in gatsby-wordpress-inline-images@1.1.0! Thanks again!

rgllm commented 4 years ago

@rgllm apologies for the delay on this. I was on vacation and then was working super hard writing the new version of gatsby-source-wordpress! I joined the Gatsby core team recently. Heads up, when gatsby-source-wordpress@v4 drops, this package will be deprecated. See gatsbyjs/gatsby#19292 for more info

I've been following your work with v4 @TylerBarnes. Good job there, would love to talk with you about that 👍

TylerBarnes commented 4 years ago

@rgllm and I'd love to hear your thoughts! Feel free to dm me on twitter (@tylbar) or comment in the epic :) Hopefully soon I'll have an experimental release ready for people to try out