Fix empty img - Githubissues

TylerBarnes / gatsby-wordpress-inline-images

Fluid images for gatsby-source-wordpress inline images in post_content

57 stars 25 forks source link

Fix empty img #7

Closed ericmarcos closed 4 years ago

ericmarcos commented 5 years ago

This pull request fixes 2 bugs:

Ignores <img src=""> tags that caused TypeError: Cannot read property replace of undefined (maybe related to #2)
Fixes an if condition that fails when trying to process null fields (needed for #6)

g-elwell commented 5 years ago

@ericmarcos - I came here to make a similar PR after encountering this bug. Took a while to figure out why my build was failing, should have checked here first!

I fixed the error in WordPress, but this PR looks good to me and I think it would help others.

PS thanks @TylerBarnes for building this plugin - it was the missing piece of the puzzle for me to finish migrating my standard WordPress site to Gatsby!

cseebach-tpc commented 5 years ago

I just got bitten by this issue as well, hope we can merge soon!