search

TylerBrock / mongo-hacker

MongoDB Shell Enhancements for Hackers
tylerbrock.github.io/mongo-hacker
MIT License
1.79k stars 235 forks source link

Installation guide is wrong: deletes soft-linked file after creating it #185

Closed salty-horse closed 5 years ago

salty-horse commented 6 years ago

The installation guide in the README is:

git clone https://github.com/TylerBrock/mongo-hacker
cd mongo-hacker
make install
cd ..
rm -rdf mongo-hacker/

make install softlinks a file in mongo-hacker/ to ~/.mongorc.js. rm then deletes that original file, so the soft link is now broken.

Also, the -d flag for rm is redundant. It's implied by -r.

michaelfdias commented 6 years ago

Great report! I sent a PR to fix it #188.

salty-horse commented 6 years ago

What about the -d flag for rm :)

michaelfdias commented 6 years ago

It also makes sense and can be improved, but it doesn't throw an error or side effect so far.