TylerLeonhardt / PSWsl

Interact with WSL over PowerShell!
MIT License
46 stars 2 forks source link

Fix a string split issue on powershell 5.1 #19

Closed patrick330602 closed 6 years ago

patrick330602 commented 6 years ago

This should help with issue #17

patrick330602 commented 6 years ago

Well, being too exited when I find the solution... I just fixed 2 issues on both powershell 5.x and 6 so that all of them works now 😄 it looks like this: image

TylerLeonhardt commented 6 years ago

Nice! Although, it looks like the (Default) is still showing up in the Distribution name.

The split you do on line 165 is supposed to remove that from going into the created object.

patrick330602 commented 6 years ago

Yeah, I notice that, Just fixed it. I just hate the fact that there exist two split for string which have a totally different behaviours. image

TylerLeonhardt commented 6 years ago

Merging this :)

TylerLeonhardt commented 6 years ago

I'll throw a release out soon-ish

TylerLeonhardt commented 6 years ago

Released! https://www.powershellgallery.com/packages/PSWsl/0.2.3 🎉 awesome work