search

TylerWilliamson / QuickWeather

Weather at a glance! Current and forecast weather for anywhere in the world!
https://play.google.com/store/apps/details?id=com.ominous.quickweather
GNU General Public License v3.0
119 stars 10 forks source link

App doesn't respect safe areas #184

Open teoAlivanoglou opened 5 days ago

teoAlivanoglou commented 5 days ago

Using Android 15 on a Google pixel 7.

Appbar draws on behind the phone's status bar.

Screenshot_20241018-170340

TylerWilliamson commented 5 days ago

I just tried to replicate this issue with an Android Virtual Device running Android 15, but I was unable to replicate it. The toolbar is in the correct location on my virtual device. Do you have any settings changed that might affect it? Immersive mode, etc? I see that you are using the 3-button navigation, but when I enable that, I still cannot replicate this issue

TylerWilliamson commented 5 days ago

In doing more research, this may be due to the "edge-to-edge" feature of Android 15. I will investigate why my virtual device isn't able to replicate the issue and see what I can do to address this in a future release

teoAlivanoglou commented 5 days ago

I just tried to replicate this issue with an Android Virtual Device running Android 15, but I was unable to replicate it. The toolbar is in the correct location on my virtual device. Do you have any settings changed that might affect it? Immersive mode, etc? I see that you are using the 3-button navigation, but when I enable that, I still cannot replicate this issue

I enabled 3-button to open the hamburger menu by swiping because gesture navigation was too annoying when I tried to do it. Otherwise I haven't changed anything

TylerWilliamson commented 4 days ago

This issue should be resolved in 2.7.4. I am still having trouble changing the navigation bar button colors when using the 3-button navigation, but I wanted to push out this fix. Please let me know if you see any other issues in Android 15. I have not yet had an opportunity to fully test things in that version

To users on previous versions of Android, the fix for this issue may cause issues for you. If you encounter any weird spacing or layout issues, please leave a comment on this issue.

I plan to close this in a week or two if there are no followup issues, but I do not mind re-opening if needed.