TylerWilliamson / QuickWeather

Weather at a glance! Current and forecast weather for anywhere in the world!
https://play.google.com/store/apps/details?id=com.ominous.quickweather
GNU General Public License v3.0
123 stars 10 forks source link

Handle long text better #81

Closed Discostu36 closed 1 year ago

Discostu36 commented 1 year ago

The app doesn't show the full text in several places. I don't know if the German strings are longer than the English ones or if it is has to do with standard font size of the device, but the app should handle this in a better way.

Screenshot_20230727-152816

Android 12 Fairphone 4

Discostu36 commented 1 year ago

It seems it has to do with Android font size settings. Above screenshot is not with standard but big font size.

TylerWilliamson commented 1 year ago

The German strings are typically longer than English ones and there is not much I can do about that. Same for large fonts and/or small screens. It's very difficult to both accomodate those situations and show all the text on the screen. Do you have suggestions for how it could be improved?

Discostu36 commented 1 year ago

I think it's good from an accessibility perspective that you respect device font settings while other apps seem to simply use hard coded font sizes.

For the hourly view you could try different approaches:

The current conditions container could get another line if text doesn't fit. Alternatively, only show third line when user extends the element.

TylerWilliamson commented 1 year ago

I think I will make the forecast cards scrollable horizontally and the current conditions multi-line. There's some technical troubles with doing that due to the current conditions animations, but I will try to include these fixes in a later release

ghost commented 1 year ago

Hi, I’m the guy who translated the app in French. I have the same problem with French strings, especially with "Today" being translated to "Aujourd’hui". Only "Aujour" appears, and the top of the following letters. I can’t think of a shorter word.

Screenshot_20230727-224715_QuickWeather

I made some mistakes I just corrected. Nothing really ugly, but maybe you shouldn’t wait too long before releasing a new version with the updated translation. Sorry for that.

Btw thank you very much for this awesome app, It is by far my favorite weather app. I ride a motorbike and being able to see the radar as soon as I open the app is very useful.

TylerWilliamson commented 1 year ago

First off, thank you for translating the app to French! I appreciate the work, and the French users will appreciate it too.

I just pushed a new version a few minutes ago, but I'll hopefully be pushing a fix next week to resolve the issue with the longer words by making sections scrollable

TylerWilliamson commented 1 year ago

Fixed in 2.4.0

TylerWilliamson commented 1 year ago

I made the detail cards scrollable in 2.4.0, but have not yet resolved the issue in the main card. In the next update, it will be multi-line. Until then, I am reopening this ticket

TylerWilliamson commented 1 year ago

Actually fixed in 2.4.1