search

Tympan / Tympan_Library

Arduino/Teensy Library for Tympan Open Source Hearing Aid
MIT License
124 stars 33 forks source link

include teensy AudioControl.h in src/ #11

Closed kxm-creare closed 6 years ago

kxm-creare commented 6 years ago

This AudioControl.h was copied from the teensy Audio library. It is the only file Tympan needs from the teensy Audio library. Including it here in /src prevents Tympan from unnecessarily including the whole Audio library (which can cause failures, specifically for the CI job).

chipaudette commented 6 years ago

Should we rename Audio_Control (and its classes within) to avoid naming confusions with the one that may be in someone's Audio library that's on their computer?

biomurph commented 6 years ago

I'm not sure if it makes a difference... Won't the compiler simply follow the path from Tympan_Library?

kxm-creare commented 6 years ago

I'm unfamiliar with compilers and have no idea what the compiler would do. Chip's suggestion would involve changing one file name and three lines of code. Either way works for me.

biomurph commented 6 years ago

Since it is taken from the teensy library, let's name it TeensyAudioControl ?

kxm-creare commented 6 years ago

I'm happy with that. Chip?

kxm-creare commented 6 years ago

Chip has approved, so I'm pushing another commit with the rename.