Tympan / Tympan_Library

Arduino/Teensy Library for Tympan Open Source Hearing Aid
MIT License
116 stars 31 forks source link

Fix earpiece app examples #51

Closed chipaudette closed 2 years ago

chipaudette commented 2 years ago

I modernized the earpiece examples:

@eyuan-creare , Have you already pointed folks to the Earpiece examples? Take a look at the new examples...I think that all of them have had their name changed. Does this mess up your interactions with the ASA folks? Do you want anything changed?

@hgeithner-creare Because of the update to the new SD and LED servicing routines, I actually touched many examples. Please test the sketches below:

chipaudette commented 2 years ago

I'm going to merge this now because I need these changes in other branches. I'm still hoping that @hgeithner-creare can do the testing, though.

eyuan-creare commented 2 years ago

@chipaudette Thanks for reworking these! I only had a bit of time for review, but I appreciated the way that you consolidated servicing routines. Seems like it will make the core function stand out more clearly.

chipaudette commented 2 years ago

@eyuan-creare , the main question for you is whether you were OK with changing the names of the examples.

image

I don't know what you're communicating with the ASA folks and I don't want to undermine your efforts....and the renaming of example programs could be exactly the kind of thing that undermines your efforts.

Are you Ok with the Earpiece examples being renamed?

eyuan-creare commented 2 years ago

Are you Ok with the Earpiece examples being renamed? @chipaudette Yes, renaming the earpiece examples is fine. I'm waiting for the hardware to arrive.

hgeithner-creare commented 2 years ago
chipaudette commented 2 years ago

You were right about something being not-right with the Earpiece examples. I updated the earpiece samples again. Tested on RevE.