Links in custom non-editable blocks open twice - Githubissues

TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.

https://www.blocknotejs.org/

Mozilla Public License 2.0

6.67k stars 459 forks source link

Links in custom non-editable blocks open twice #1040

Open mfanselmo opened 2 months ago

mfanselmo commented 2 months ago

Describe the bug Hey, when you have a link inside of a custom non editable block, with the usual stuff to open it in a new page, it opens twice. Seems to be related to thishttps://github.com/ueberdosis/tiptap/issues/4877, resolved by this https://github.com/ueberdosis/tiptap/pull/5040.

To Reproduce

https://stackblitz.com/edit/github-a6kavu-fbsh1d?file=App.tsx

Click on the google link there, make sure the popups are able to open on stackblitz (I had to enable them to see the issue). Two tabs should open with the google link

https://github.com/user-attachments/assets/4c2238ca-73f8-4b9a-b5ea-d9c45fe6b240

Misc

Node version:
Package manager:
Browser:
[ ] I'm a sponsor and would appreciate if you could look into this sooner than later 💖

matthewlipski commented 2 months ago

Nice find! Thanks for providing the TipTap links too👍