TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.
https://www.blocknotejs.org/
Mozilla Public License 2.0
6.64k stars 457 forks source link

Regression: Sticky tool buttons #1171

Open serpent213 opened 2 weeks ago

serpent213 commented 2 weeks ago

Block's tool buttons don't scroll with content on 0.17.1:

https://github.com/user-attachments/assets/1bd8d75f-0c6a-4802-8055-25e0888c15c7

I'm using shadcn components. Buttons behave as expected on 0.16.0.

Please let me know if you need more information and/or a sandbox.

Misc

YousefED commented 2 weeks ago

Thanks, seems like a regression indeed

serpent213 commented 1 week ago

Just noticed another small glitch when extending the slash menu, following the Alert example.

0.16.0:

Screenshot 2024-10-28 at 11 55 51

0.17.1:

Screenshot 2024-10-28 at 11 43 52
YousefED commented 1 week ago

Just noticed another small glitch when extending the slash menu, following the Alert example.

0.16.0: Screenshot 2024-10-28 at 11 55 51

0.17.1: Screenshot 2024-10-28 at 11 43 52

this seems unrelated and you just need to pass slashMenu=false to the view I think?

serpent213 commented 1 week ago

My code looks like this:

    return (
        <BlockNoteView
            editor={editor}
            emojiPicker={false}
            slashMenu={false}
            theme="light"
            onChange={() => {
                debouncedPushEvent(editor.document as Block[])
            }}
        >
            <SuggestionMenuController
                triggerCharacter={"/"}
                getItems={async (query) =>
                    // Gets all default slash menu items and `insertAlert` item.
                    filterSuggestionItems([...getDefaultReactSlashMenuItems(editor), insertAlert(editor)], query)
                }
            />
        </BlockNoteView>
    )

Also, the Emoji Picker is still visible, even though set to false.

Did I get it wrong?

YousefED commented 1 week ago

@serpent213 this should be ok. Could you create a separate issue with a link to a reproducible sandbox (stackblitz), and remove your comments from this issue?