Only show the side menu when clicking on a block (#748)

TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.

https://www.blocknotejs.org/

Mozilla Public License 2.0

5.91k stars 386 forks source link

Only show the side menu when clicking on a block (#748) #765

Closed bensku closed 1 month ago

bensku commented 1 month ago

Since #395, clicking anywhere in the page has caused the side menu to be briefly shown. This fixes #353, but causes flickering in UI as shown in video attachment of #748.

This fixes the flickering by only showing the side menu when a block was clicked. I also made the side menu appear on that block, to avoid visual consistency issues on mobile.

Tested on desktop Firefox and Chromium, and Firefox for Android. Fixes #748.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
blocknote	✅ Ready (Inspect)	Visit Preview	May 26, 2024 0:51am

vercel[bot] commented 1 month ago

@bensku is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

matthewlipski commented 1 month ago

Thanks for your submission! I took a look at what the desired behaviour should be and we're gonna use a slightly different approach instead where clicks now hide the side menu, but only when it's frozen - this seems to be closest to Notion's UX. Added those changes to PR #769. Thanks again!