fix: Custom inline content crash

TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.

https://www.blocknotejs.org/

Mozilla Public License 2.0

6.46k stars 440 forks source link

fix: Custom inline content crash #788

Closed conr closed 3 months ago

conr commented 4 months ago

Fixes https://github.com/TypeCellOS/BlockNote/issues/750

Before

After

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
blocknote	✅ Ready (Inspect)	Visit Preview	Jun 3, 2024 11:30am
blocknote-website	✅ Ready (Inspect)	Visit Preview	Jun 3, 2024 11:30am

vercel[bot] commented 4 months ago

@conr is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

YousefED commented 4 months ago

Thanks @conr. This looks like a good temporary fix, but I still want to figure out the root cause (why is contentComponent undefined). If the CI passes I'd be happy to merge this regardless

conr commented 3 months ago

@YousefED That's very fair!

Looks like CI is passing now