fix: Mantine sub-menu rendering in the DOM

TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.

https://www.blocknotejs.org/

Mozilla Public License 2.0

5.9k stars 384 forks source link

fix: Mantine sub-menu rendering in the DOM #802

Closed matthewlipski closed 4 weeks ago

matthewlipski commented 1 month ago

Right now, Mantine sub-menu dropdowns are being rendered within the menu item that opens them. This throws an error as the menu item is a button, and the dropdown contains more menu items which are also buttons (button elements are not valid descendants of other button elements).

This PR makes sub menu dropdowns get rendered in the same dropdown as the menu items which trigger them, same as how Ariakit and ShadCN do it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
blocknote	✅ Ready (Inspect)	Visit Preview	Jun 5, 2024 4:55pm
blocknote-website	✅ Ready (Inspect)	Visit Preview	Jun 5, 2024 4:55pm