TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.
https://www.blocknotejs.org/
Mozilla Public License 2.0
5.9k stars 384 forks source link

fix(ui): missing margin in checklist while in RTL #827

Closed zaaakher closed 3 weeks ago

zaaakher commented 3 weeks ago

This tiny PR fixes a missing space next to the checkbox in checklists while in an RTL user interface.

Before

image

After

image


Althought on a side note, 1.2em feels a little too large of a space between the checkbox and the text. I suggest 0.5em.

1.2 em

image

0.5 em

image

If you agree 0.5em is better spacing, let me know and I will add a commit changing it from 1.2 to 0.5

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:52am
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:52am
vercel[bot] commented 3 weeks ago

@zaaakher is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

zaaakher commented 3 weeks ago

1.2em feels a little too large of a space between the checkbox and the text. I suggest 0.5em.

@YousefED Any thoughts on this part? I couldn't quickly find any resources online to support my suggestion about the standard space between checkboxes and their title so I asked chatGPT 👇

image

YousefED commented 3 weeks ago

I agree a smaller margin looks better and is more inline with Notion. Looping in @matthewlipski for this as he made the original check box

zaaakher commented 3 weeks ago

Ok I just decreased it to 0.5em 👍

matthewlipski commented 3 weeks ago

I agree a smaller margin looks better and is more inline with Notion. Looping in @matthewlipski for this as he made the original check box

Agreed, does look closer to Notion so I changed the other list item blocks to use the same margin also