TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.
https://www.blocknotejs.org/
Mozilla Public License 2.0
5.9k stars 384 forks source link

fix: update `remarkStringify` config #841

Closed zaaakher closed 2 weeks ago

zaaakher commented 3 weeks ago

Fixes #834


For some reason, returning the text node within the remarkStringify handler option solved the issue with an extra backslash before the first bracket.

.use(remarkStringify, { handlers: { text: (node) => node.value } })

Before

339166596-baf435ae-a584-4e66-be80-64267319d125

After

blocknote-escape-checklist-solved

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:10am
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 0:10am
vercel[bot] commented 3 weeks ago

@zaaakher is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

matthewlipski commented 3 weeks ago

Oh nice, this looks like an elegant fix:) I'll update the unit tests and then I think we can merge, thanks for your contribution!

zaaakher commented 3 weeks ago

Thanks @matthewlipski . I will remember to run npm run test next time 😁

TheMikeyRoss commented 2 weeks ago

Nice thanks @zaaakher , would this be included in 0.14.2 ?

zaaakher commented 2 weeks ago

Nice thanks @zaaakher , would this be included in 0.14.2 ?

Yes I believe so. Although it's up to the maintainers.