search

TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.
https://www.blocknotejs.org/
Mozilla Public License 2.0
5.89k stars 381 forks source link

Update: ShadowRoot support #849

Closed dcadavez66 closed 1 week ago

dcadavez66 commented 2 weeks ago
  1. Core package updated to ensure BlockNote can be used in ShadowRoots;
  2. pasteExtension.ts updated to also support image pasting into the editor;
  3. Updated version for the Arabic translation file;

TODO:The changes related to the first point primarily involve replacing the use of document with the root property, which can be either Document or ShadowRoot. This property is accessed from pmView. In files where pmView is not available, the root property should be accessed from _editor.tiptapEditor.view.root. To ensure consistency and ease for future modifications, there should be a standardized method for accessing this value. This will enable everyone making future changes to use this standard method instead of directly accessing the document.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 24, 2024 7:04pm
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 24, 2024 7:04pm
vercel[bot] commented 2 weeks ago

@dcadavez66 is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

matthewlipski commented 1 week ago

I added most of the changes mentioned in my review, only thing left is the type casting comment! @dcadavez66 @YousefED