Bug: Display Create Link Toolbar when state editor is non-editable

TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.

https://www.blocknotejs.org/

Mozilla Public License 2.0

5.89k stars 381 forks source link

Bug: Display Create Link Toolbar when state editor is non-editable #850

Closed lamtuanamc closed 1 week ago

lamtuanamc commented 1 week ago

Describe the bug: In debug mode, the "Create Link" button in the toolbar is clickable when I highlight text, even though the editor state is set to non-editable and the formattingToolbar prop is set to false.

This issue has not been observed in the production environment.

https://github.com/TypeCellOS/BlockNote/assets/37234239/542a3768-38c9-4a06-9657-ff907ea539ad

matthewlipski commented 1 week ago

Hmm I can't seem to reproduce this on either the built or dev environment. Could you create a sandbox to see if this issue is specific to your project?

lamtuanamc commented 1 week ago

@matthewlipski I have customized CreateLinkButton.tsx so when you update the core library to display the button to download files and images, I'm missing the conditions to hide the button to create link. Sorry for the lack of information.