TypeCellOS / TypeCell

https://www.typecell.org
GNU Affero General Public License v3.0
444 stars 29 forks source link

Look into TipTap's ReactRenderer and possibly refactor components into FC's #59

Closed pvunderink closed 3 years ago

pvunderink commented 3 years ago

TipTap offers a class (ReactRenderer) to render react elements outside of the regular React tree / DOM. Such as when we want a popup menu to appear. However this renderer practically forces us to use regular React components if we want to pass outside events to the component. It might be worth looking into this when we are start using this class more extensively, to see if there might be a better approach.

If it seems possible to use FC's for the purpose described above, then the following task can be completed:

YousefED commented 3 years ago

fixed in https://github.com/YousefED/typecell-next/pull/131